From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by sourceware.org (Postfix) with ESMTPS id E2DE63861013 for ; Thu, 20 Aug 2020 12:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E2DE63861013 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f67.google.com with SMTP id f7so1840552wrw.1 for ; Thu, 20 Aug 2020 05:17:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xhvb7FHY4GmbwBkFrkCoe+ZuDXq67BX6WtDwZl4k3xQ=; b=mQBO5oKWqldPrswBpmUBv2KhEqvvtnkgkphnjTXHeL5LEAW4t6tgaoUp7bVt8TNGjp B0zkkTMd6BIRZRqwRvqb39vT/ZUef+VrZjF7vytD+K5ZvKcccdXlIEm9Z8gfxR7aCcCN Il05bxMy5urOlij8TOA8nhVcoDQHSyRCGYlFJj86Y5XhKXkwuLIJY7lph5Ko6mHdGHJS CuSGrtCtehXJKv+qJiktkWFg2iVRx4y1OamfKJ+tbh8e+0V6iET44I+VycphoLURb7+u PwIQY8yyq46vm9O7vZNzDSpw+1jmnpD8bZ008cel/MNGsgUYvXKeHcMYufHAgBHQDEEh 9f4A== X-Gm-Message-State: AOAM530jOf8Glrq8JmKLEDwjc2lJFFk7DftxsiK6L4zYuK3tyae8RACW d1fI4TAb2Hzcq9ln2sgUQ4QAIUyvhLtpVQ== X-Google-Smtp-Source: ABdhPJw+NcGn6htR7qtSJMOhwb6J82NiIic5wW36A9/k4hkvycebqN/w8Qgr99Q+AeyNxUTca7wZIg== X-Received: by 2002:adf:b1cf:: with SMTP id r15mr3193844wra.118.1597925840380; Thu, 20 Aug 2020 05:17:20 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:56ee:75ff:fe8d:232b? ([2001:8a0:f905:5600:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id o2sm3705033wrj.21.2020.08.20.05.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2020 05:17:19 -0700 (PDT) Subject: Re: [PATCH] Disable Clang's integrated assembler for two testcases To: Gary Benson , gdb-patches@sourceware.org References: <1597848954-21937-1-git-send-email-gbenson@redhat.com> From: Pedro Alves Message-ID: <03afeec7-e1e2-0403-03b6-04a3dd5916b6@palves.net> Date: Thu, 20 Aug 2020 13:17:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1597848954-21937-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2020 12:17:24 -0000 On 8/19/20 3:55 PM, Gary Benson via Gdb-patches wrote: > Hi all, > > gdb.dwarf2/dw2-dir-file-name.exp fails to build using Clang because > the generated assembly language contains .ascii directives with more > than one string literal. gdb.dwarf2/dw2-restore.exp fails to build > using Clang because it contains .func and .endfunc directives. > This patch causes Clang to invoke the system assembler to assemble > the relevant files. > > Checked on Fedora 32 x86_64, GCC and clang. Ok to commit? Given we have this in most gdb.dwarf2 tests: # This test can only be run on targets which support DWARF-2 and use gas. ^^^^^^^^^^^ this seems fine to me. > > Cheers, > Gary > > -- > gdb/testsuite/ChangeLog: > > * gdb.dwarf2/dw2-dir-file-name.exp: Use system assembler > when compiling with clang. > * gdb.dwarf2/dw2-restore.exp: Likewise Missing period after "Likewise". Thanks, Pedro Alves