From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 3DDC0385041A for ; Tue, 25 Aug 2020 14:54:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3DDC0385041A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-IRtDR3xmPEy_2BVLrsOScQ-1; Tue, 25 Aug 2020 10:54:36 -0400 X-MC-Unique: IRtDR3xmPEy_2BVLrsOScQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F39F510ABDCF; Tue, 25 Aug 2020 14:54:34 +0000 (UTC) Received: from blade.nx (ovpn-115-34.ams2.redhat.com [10.36.115.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id C22595D9D3; Tue, 25 Aug 2020 14:54:34 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 12276816CCA9; Tue, 25 Aug 2020 15:54:33 +0100 (BST) Date: Tue, 25 Aug 2020 15:54:33 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Disable Clang's integrated assembler for two testcases Message-ID: <20200825145433.GB17510@blade.nx> References: <1597848954-21937-1-git-send-email-gbenson@redhat.com> <03afeec7-e1e2-0403-03b6-04a3dd5916b6@palves.net> <20200825143514.GA17063@blade.nx> <08ab4c1d-40ad-8eac-f40e-e880a28f7e30@palves.net> MIME-Version: 1.0 In-Reply-To: <08ab4c1d-40ad-8eac-f40e-e880a28f7e30@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 14:54:43 -0000 Pedro Alves wrote: > On 8/25/20 3:35 PM, Gary Benson wrote: > >>> * gdb.dwarf2/dw2-dir-file-name.exp: Use system assembler > >>> when compiling with clang. > >>> * gdb.dwarf2/dw2-restore.exp: Likewise > >> > >> Missing period after "Likewise". > > > > I pushed the wrong commit, without the period added. Should I push > > a correction? > > Sure, why not? Cool, I've done this now. Thanks for you review! Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat