Re: [PATCH] Require GNU make 3.82

[Kevin Buettner <kevinb@redhat.com>]

On Wed, 15 Jul 2020 19:31:44 +0200
Tom de Vries <tdevries@suse.de> wrote:

> On 7/15/20 7:14 PM, Kevin Buettner wrote:
> > On Wed, 15 Jul 2020 09:46:58 +0200
> > Tom de Vries <tdevries@suse.de> wrote:
> >   
> >> On 7/14/20 4:30 PM, Tom de Vries wrote:  
> >>> On 7/18/19 12:57 PM, Alan Hayward wrote:    
> >>>>
> >>>>    
> >>>>> On 18 Jul 2019, at 07:17, Eli Zaretskii <eliz@gnu.org> wrote:
> >>>>>    
> >>>>>> From: Alan Hayward <Alan.Hayward@arm.com>
> >>>>>> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
> >>>>>> Date: Mon, 15 Jul 2019 10:11:29 +0000
> >>>>>>
> >>>>>> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be.    
> >>>>>
> >>>>> Which feature of Make 3.82 and later is required to successfully
> >>>>> build gdbserver?
> >>>>>    
> >>>>
> >>>> It’s not a specific feature in 3.82 that is required.
> >>>>
> >>>> It looks like it is a bug in 3.81. The GDB makefile isn’t doing anything special
> >>>> and everything works using 3.82 upwards.
> >>>>
> >>>> Rewriting the makefile to work around the issue is probably going to be a little
> >>>> messy.
> >>>>    
> >>>
> >>> This patch (on top of gdb 9.1) works around the issue for make 3.81.
> >>>
> >>> Build with make 3.81 and make 4.2.1 on x86_64-linux.    
> >>
> >> And here (
> >> https://sourceware.org/pipermail/gdb-patches/2019-December/163800.html )
> >> is a patch (with a detailed analysis of the actual failure) on master
> >> that fixes the build with 3.81.  
> > 
> > So Bernd's patch should be backported to 9.1?  
> 
> Um, we've already released 9.2, and I presume closed the branch? So I'm
> not sure what you mean.

Back on the July 14, you posted a patch relative to gdb 9.1 which works around the make 3.81 issue.  But it seems that Bernd also has a patch from late last year which fixes that issue.  (It appears to me that Bernd's patch is on the trunk, but I haven't checked to see what branches Bernd's patch might be on.)

Is Bernd's patch insufficient to fix the 3.81 issues that you're seeing?

Kevin