From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 1DE403840C19 for ; Wed, 15 Jul 2020 19:14:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DE403840C19 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-3n4exnAuPlCzTg7Nt6IOYA-1; Wed, 15 Jul 2020 15:14:39 -0400 X-MC-Unique: 3n4exnAuPlCzTg7Nt6IOYA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1005C800C64; Wed, 15 Jul 2020 19:14:38 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-21.phx2.redhat.com [10.3.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B112710A0; Wed, 15 Jul 2020 19:14:37 +0000 (UTC) Date: Wed, 15 Jul 2020 12:14:36 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org, Alan Hayward , Eli Zaretskii , nd Subject: Re: [PATCH] Require GNU make 3.82 Message-ID: <20200715121436.7c005c10@f32-m1.lan> In-Reply-To: References: <20190715101124.77677-1-alan.hayward@arm.com> <83v9vzyih8.fsf@gnu.org> <1298B553-A75A-4D06-9AC4-4F924B045C16@arm.com> <0803f7e7-8564-c079-e1ee-e9fb3497a319@suse.de> <3def7bcb-7345-11a7-8c59-1bb8784ced38@suse.de> <20200715101406.135c5bd0@f32-m1.lan> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 19:14:54 -0000 On Wed, 15 Jul 2020 19:31:44 +0200 Tom de Vries wrote: > On 7/15/20 7:14 PM, Kevin Buettner wrote: > > On Wed, 15 Jul 2020 09:46:58 +0200 > > Tom de Vries wrote: > > =20 > >> On 7/14/20 4:30 PM, Tom de Vries wrote: =20 > >>> On 7/18/19 12:57 PM, Alan Hayward wrote: =20 > >>>> > >>>> =20 > >>>>> On 18 Jul 2019, at 07:17, Eli Zaretskii wrote: > >>>>> =20 > >>>>>> From: Alan Hayward > >>>>>> CC: nd , Alan Hayward > >>>>>> Date: Mon, 15 Jul 2019 10:11:29 +0000 > >>>>>> > >>>>>> Gdbserver has failed to build with GNU make 3.81 since commit 08f1= 0e02be. =20 > >>>>> > >>>>> Which feature of Make 3.82 and later is required to successfully > >>>>> build gdbserver? > >>>>> =20 > >>>> > >>>> It=E2=80=99s not a specific feature in 3.82 that is required. > >>>> > >>>> It looks like it is a bug in 3.81. The GDB makefile isn=E2=80=99t do= ing anything special > >>>> and everything works using 3.82 upwards. > >>>> > >>>> Rewriting the makefile to work around the issue is probably going to= be a little > >>>> messy. > >>>> =20 > >>> > >>> This patch (on top of gdb 9.1) works around the issue for make 3.81. > >>> > >>> Build with make 3.81 and make 4.2.1 on x86_64-linux. =20 > >> > >> And here ( > >> https://sourceware.org/pipermail/gdb-patches/2019-December/163800.html= ) > >> is a patch (with a detailed analysis of the actual failure) on master > >> that fixes the build with 3.81. =20 > >=20 > > So Bernd's patch should be backported to 9.1? =20 >=20 > Um, we've already released 9.2, and I presume closed the branch? So I'm > not sure what you mean. Back on the July 14, you posted a patch relative to gdb 9.1 which works aro= und the make 3.81 issue. But it seems that Bernd also has a patch from lat= e last year which fixes that issue. (It appears to me that Bernd's patch i= s on the trunk, but I haven't checked to see what branches Bernd's patch mi= ght be on.) Is Bernd's patch insufficient to fix the 3.81 issues that you're seeing? Kevin