Re: [PATCH] Require GNU make 3.82

[Alan Hayward <Alan.Hayward@arm.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1431 bytes --]



> On 16 Jul 2019, at 01:51, Kevin Buettner <kevinb@redhat.com> wrote:
> 
> On Mon, 15 Jul 2019 10:11:29 +0000
> Alan Hayward <Alan.Hayward@arm.com> wrote:
> 
>> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be.
>> 
>> Update the NEWS file to state that versions earlier than 3.82 are not
>> supported.
>> 
>> 3.82 was released in 2010, 3.81 was released 2006. A quick investigation
>> of the default GNU make version provided across various distros found the
>> earliest provided version to be 3.82:
>> *RHEL 7, Centos 6 - make 3.82
>> *Fedora 27 - make 4.2.1
>> *OpenSuse 42.2, SLES11 - make 4.2.1
>> *Ubuntu 16.04/18.04 - make 4.1
>> *Debian Jessie - make 4.0
>> 
>> Note that Glibc requires at least 4.0, whereas GCC still allows 3.81.
>> 
>> gdb/ChangeLog:
>> 
>> 2019-07-15  Alan Hayward  <alan.hayward@arm.com>
>> 
>> 	* NEWS: Require GNU make 3.82.
> 
> This seems okay to me, though I think that Eli needs to approve it. 
> Regardless, I think you should wait a few days to push it in case
> there are any objections.  (The other solution is to rewrite the
> Makefile rules that caused the breakage.)
> 
> Kevin

Agreed. I’ll give it a good week after the last comment before pushing.

I did have a look at why the changes broke. I couldn’t see any reason
why it would break, other than it being a bug in 3.81.


Alan.\x16º&Öéj×!zÊÞ¶êçמùã©b²Ö«r\x18\x1dn–­r\x17¬