From: Gary Benson <gbenson@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages
Date: Wed, 8 Jul 2020 11:06:00 +0100 [thread overview]
Message-ID: <20200708100600.GA10907@blade.nx> (raw)
In-Reply-To: <2d73efe4dc489f06fd4e67aa18979e5b655b7100.1594198122.git.andrew.burgess@embecosm.com>
Andrew Burgess wrote:
> This commit changes the output of 'show architecture'. Here is a
> session before this commit:
>
> (gdb) show architecture
> The target architecture is set automatically (currently i386)
> (gdb) set architecture mips
> The target architecture is assumed to be mips
> (gdb) show architecture
> The target architecture is assumed to be mips
> (gdb)
>
> After this commit the session now looks like this:
>
> (gdb) show architecture
> The target architecture is set to "auto" (currently i386).
This is potentially bikeshedding, but should the i386 in this
line be enclosed in quotes also?
Otherwise this LGTM.
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
next prev parent reply other threads:[~2020-07-08 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:54 [PATCH 0/2] Changes to show architecture/endian message Andrew Burgess
2020-07-08 8:54 ` [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson [this message]
2020-07-15 2:06 ` Simon Marchi
2020-07-15 9:36 ` Andrew Burgess
2020-07-17 15:52 ` Gary Benson
2020-07-08 8:54 ` [PATCH 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson
2020-07-13 18:24 ` [PATCH 0/2] Changes to show architecture/endian message Tom Tromey
2020-07-14 12:27 ` [PUSHED " Andrew Burgess
2020-07-14 12:27 ` [PUSHED 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-14 12:27 ` [PUSHED 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708100600.GA10907@blade.nx \
--to=gbenson@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox