From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Simon Marchi <simark@simark.ca>
Cc: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages
Date: Wed, 15 Jul 2020 10:36:30 +0100 [thread overview]
Message-ID: <20200715093630.GE2737@embecosm.com> (raw)
In-Reply-To: <0ceca48f-a952-ceb3-eb4c-09c65f11bdf3@simark.ca>
* Simon Marchi <simark@simark.ca> [2020-07-14 22:06:05 -0400]:
> On 2020-07-08 6:06 a.m., Gary Benson via Gdb-patches wrote:
> > This is potentially bikeshedding, but should the i386 in this
> > line be enclosed in quotes also?
>
> This is not bikeshedding, IMO. Consistency and attention to details make a tool look much better!
I agree, and I'm always happy to get feedback like this.
FYI - this change made it into the final patch I merged.
Thanks,
Andrew
next prev parent reply other threads:[~2020-07-15 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:54 [PATCH 0/2] Changes to show architecture/endian message Andrew Burgess
2020-07-08 8:54 ` [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson
2020-07-15 2:06 ` Simon Marchi
2020-07-15 9:36 ` Andrew Burgess [this message]
2020-07-17 15:52 ` Gary Benson
2020-07-08 8:54 ` [PATCH 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson
2020-07-13 18:24 ` [PATCH 0/2] Changes to show architecture/endian message Tom Tromey
2020-07-14 12:27 ` [PUSHED " Andrew Burgess
2020-07-14 12:27 ` [PUSHED 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-14 12:27 ` [PUSHED 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715093630.GE2737@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox