From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 414F6385E444 for ; Wed, 8 Jul 2020 10:06:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 414F6385E444 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-HUNl9Z_vOzqyyx8Dxeh5vQ-1; Wed, 08 Jul 2020 06:06:02 -0400 X-MC-Unique: HUNl9Z_vOzqyyx8Dxeh5vQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44C6C107ACCA; Wed, 8 Jul 2020 10:06:01 +0000 (UTC) Received: from blade.nx (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1712F79247; Wed, 8 Jul 2020 10:06:01 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 2E387816CCA9; Wed, 8 Jul 2020 11:06:00 +0100 (BST) Date: Wed, 8 Jul 2020 11:06:00 +0100 From: Gary Benson To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Message-ID: <20200708100600.GA10907@blade.nx> References: <2d73efe4dc489f06fd4e67aa18979e5b655b7100.1594198122.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 In-Reply-To: <2d73efe4dc489f06fd4e67aa18979e5b655b7100.1594198122.git.andrew.burgess@embecosm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 10:06:05 -0000 Andrew Burgess wrote: > This commit changes the output of 'show architecture'. Here is a > session before this commit: > > (gdb) show architecture > The target architecture is set automatically (currently i386) > (gdb) set architecture mips > The target architecture is assumed to be mips > (gdb) show architecture > The target architecture is assumed to be mips > (gdb) > > After this commit the session now looks like this: > > (gdb) show architecture > The target architecture is set to "auto" (currently i386). This is potentially bikeshedding, but should the i386 in this line be enclosed in quotes also? Otherwise this LGTM. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat