Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 5/7] Close file handle of empty history file
Date: Mon, 25 May 2020 20:56:57 +0200	[thread overview]
Message-ID: <20200525185659.59346-6-ssbssa@yahoo.de> (raw)
In-Reply-To: <20200525185659.59346-1-ssbssa@yahoo.de>

Happened while trying to reproduce a gdb.base/gdbinit-history.exp failure:
warning: Could not rename C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history to C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history-gdb5228~: Permission denied

I had an empty gdbinit-history.gdb_history-gdb5228~ file, and the file
handle was not closed on startup, so it couldn't rename it at the end
when trying to write a new one.

readline/readline/ChangeLog:

2020-05-25  Hannes Domani  <ssbssa@yahoo.de>

	* histfile.c (read_history_range): Close file handle.
---
 readline/readline/histfile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/readline/readline/histfile.c b/readline/readline/histfile.c
index dc64bde1c5..a8a92aa360 100644
--- a/readline/readline/histfile.c
+++ b/readline/readline/histfile.c
@@ -305,6 +305,7 @@ read_history_range (const char *filename, int from, int to)
   if (file_size == 0)
     {
       free (input);
+      close (file);
       return 0;	/* don't waste time if we don't have to */
     }
 
-- 
2.26.2



  parent reply	other threads:[~2020-05-25 18:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200525185659.59346-1-ssbssa.ref@yahoo.de>
2020-05-25 18:56 ` Windows testsuite failures Hannes Domani
2020-05-25 18:56   ` [PATCH 1/7] Fix function argument and return value locations Hannes Domani
2020-05-25 21:02     ` Simon Marchi
2020-05-25 21:32       ` Hannes Domani
2020-05-25 22:14         ` Simon Marchi
2020-05-25 23:03           ` Hannes Domani
2020-05-26 16:14             ` Simon Marchi
2020-05-26 20:43         ` Tom Tromey
2020-05-25 18:56   ` [PATCH 2/7] Handle Windows drives in auto-load script paths Hannes Domani
2020-05-26 16:04     ` Jon Turney
2020-05-26 16:31       ` Hannes Domani
2020-05-26 16:05     ` Christian Biesinger
2020-05-26 16:25       ` Hannes Domani
2020-05-26 16:31         ` Christian Biesinger
2020-05-26 16:40           ` Hannes Domani
2020-05-26 16:42             ` Christian Biesinger
2020-05-26 17:14               ` Hannes Domani
2020-05-25 18:56   ` [PATCH 3/7] Handle Windows drives in rbreak paths Hannes Domani
2020-05-25 18:56   ` [PATCH 4/7] Use errno value of first openp failure Hannes Domani
2020-05-26 20:37     ` Tom Tromey
2020-05-25 18:56   ` Hannes Domani [this message]
2020-05-26 16:37     ` [PATCH 5/7] Close file handle of empty history file Christian Biesinger
2020-05-26 17:42       ` Hannes Domani
2020-05-27 14:33         ` Tom Tromey
2020-05-27 17:37           ` Hannes Domani
2020-05-27 18:27             ` Christian Biesinger
2020-05-25 18:56   ` [PATCH 6/7] Move exit_status_set_internal_vars out of GLOBAL_CURDIR Hannes Domani
2020-05-26 20:45     ` Tom Tromey
2020-05-27 17:50       ` Hannes Domani
2020-05-25 18:56   ` [PATCH 7/7] Reset Windows hardware breakpoints on executable's entry point Hannes Domani
2020-05-27 12:07     ` Pedro Alves
2020-05-27 14:48       ` Pedro Alves
2020-05-27 15:39         ` Hannes Domani
2020-05-31 15:54           ` Pedro Alves
2020-05-31 16:37     ` Pedro Alves
2020-06-07 12:56       ` Hannes Domani
2020-07-08 17:43         ` Hannes Domani
2020-10-09 18:22         ` Pedro Alves
2020-10-09 18:51           ` Hannes Domani via Gdb-patches
2020-10-12 11:13             ` Pedro Alves
2020-10-12 17:21       ` Tom Tromey
2020-10-12 17:22         ` Tom Tromey
2020-05-28 18:15   ` Windows testsuite failures Christian Biesinger
2020-05-28 18:37     ` Hannes Domani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200525185659.59346-6-ssbssa@yahoo.de \
    --to=ssbssa@yahoo.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox