From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic304-22.consmr.mail.ir2.yahoo.com (sonic304-22.consmr.mail.ir2.yahoo.com [77.238.179.147]) by sourceware.org (Postfix) with ESMTPS id 0C3D53892020 for ; Mon, 25 May 2020 18:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C3D53892020 X-YMail-OSG: nC2HczwVM1kJsHyXsReZ9e8U7wW_XlN_eQnJM0xeCwyGaBGCBDS9cECsxK9mUud rzueACSrc5AQc_ealrEENFyG0sT7i76VzFHq1whGhd2wwM7q7la3URlTpjW2KFEV1cM7HokQzUrO nPnHVtQXPRJfwsh4RHYXLKz1ekPKjOzT0VvjfHwqq5mtGT_ZgRaoFsgVp5j1rSWcnET.OBIbVkot hcBqDPKC9HIa90Hh9JADL572wd8WtMBrsVbCNKHHxzhmZjmk7fw41VSAwd1iIHVDV2vHv7IQ1w1v ei92Cb9zHVa3xvaPuoJrsWYnn9stnHYLDlK_oDSlFJZCVXLNqXlQF4mf9t10aaeZ4BSzwpWnOPIM 8ZUlkaz2UZRTUTQUqpcX6.WKD7oQNjoaKPURvQYbxMamlL.96VGNxOGiOVesRXu450oapS9z8e4m FtPEH74_xyqMriYdTuX5yCmT_PHTrEgFoFg10ggEU6W7RNPkKK2z9A7jZc4K2mJbGnXn7_bjNPO8 4Ujyi.AoKgThbyUNUNRlbeb.IzUJx33D3rn6c04zuN65UdlcdUV2qqyRh3NMmhGpXxAt0YEjrOVC Pse5F3GNr8eLaxACe1Udc3WJjkfW34uPgzKQwY2soI13PawoS4WI7to0AxKTckzxg7UY9pmpWvXk rHlh7Vz4UdBiaUpRVIm8H9nSrVurrCQ6hLXPrlbzmRUaLt1piSSS1r4SfnkH6NLS9wZYRdOzK.Ql TY2e0poDV1NPKmMOttFWIj8e_TKpqBRfE6qJxp5nN12c5JZcuHu1iCADQ6XR1A.3gYHC5FEjB5SJ 3fNTtf8mFq5XYTV6_.g9QRH7fkwD_L2iuqoNVlgvx9o6jPpKpZ6cjMA9tkaaFT181lBo2.BpIMd7 fl9_Cn6MhsrqdV9Ou4f9CWDUHtISyqLbQ2Gt34LxvNPRPi1iTRv7WVg6Ke5B.YQd4tNLPnsNq2aL y9DM4q8XkJZ.S12KqyGoC4u4AREizz_aab_fvPff0r1RIOg2kq5N7jUFKEJOqWUseeMm.2zYZSqY Ui1FI0ulnYXc1DHYGB.pgR3PKJeDRxsWgHqmPJwhp0mg2waHyrBV0ytMiR1IAAdpmLOfc2T.WLKa Ql0bdSp5o00POm3lfrBblsIin59yDzzmjNkl8rxFiVDnVdiW99OEDYTYZbJLRlEM79lrGoaFre8R yqd1aGYGM8c5qwRRTBOA05V.8UWPTtUIBRoIVw8rkrV8barJb2g0ecM6RU2QOOwgXnjdmbttWlZa BVAKXjYEN20luFP7e6OsAkWKt9qlQ8BMVdaXR3P1uVkQEJaT9bIcNRcIG05NGAlbdHDzLW3fqIlF ksOPA6H_rOYOevdnQp9YfKywniHQep0Nt50E5KM0jkFHN89DECHKA4Y7PzhFIzMtFPHYIzQEGFz3 H9pcatBt5Tqiux59bG8xV.KbsjbcnB30- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Mon, 25 May 2020 18:57:37 +0000 Received: by smtp423.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8e39fad2073e4e08fe0b9c0b29120b31; Mon, 25 May 2020 18:57:34 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Subject: [PATCH 5/7] Close file handle of empty history file Date: Mon, 25 May 2020 20:56:57 +0200 Message-Id: <20200525185659.59346-6-ssbssa@yahoo.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200525185659.59346-1-ssbssa@yahoo.de> References: <20200525185659.59346-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 200524-0, 05/24/2020), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 18:57:44 -0000 Happened while trying to reproduce a gdb.base/gdbinit-history.exp failure: warning: Could not rename C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history to C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history-gdb5228~: Permission denied I had an empty gdbinit-history.gdb_history-gdb5228~ file, and the file handle was not closed on startup, so it couldn't rename it at the end when trying to write a new one. readline/readline/ChangeLog: 2020-05-25 Hannes Domani * histfile.c (read_history_range): Close file handle. --- readline/readline/histfile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/readline/readline/histfile.c b/readline/readline/histfile.c index dc64bde1c5..a8a92aa360 100644 --- a/readline/readline/histfile.c +++ b/readline/readline/histfile.c @@ -305,6 +305,7 @@ read_history_range (const char *filename, int from, int to) if (file_size == 0) { free (input); + close (file); return 0; /* don't waste time if we don't have to */ } -- 2.26.2