From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
gdb-patches@sourceware.org, Shahab Vahedi <shahab@synopsys.com>,
Claudiu Zissulescu <claziss@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH] gdb: Catch exceptions if the source file is not found
Date: Thu, 06 Feb 2020 13:19:00 -0000 [thread overview]
Message-ID: <20200206131932.GA1290@gmail.com> (raw)
In-Reply-To: <87lfpyxcp3.fsf@tromey.com>
Hi Tom,
On Thu, Jan 23, 2020 at 11:14:16AM -0700, Tom Tromey wrote:
> >>>>> "Shahab" == Shahab Vahedi <shahab.vahedi@gmail.com> writes:
>
> Shahab> It is just a matter of time for me to write my _first_ test.
> Shahab> If the changes are OK, I will submit the test in a separate
> Shahab> patch if you don't mind. I just don't want this fix fall
> Shahab> through the cracks as apparently it did once according to
> Shahab> Tom.
>
> Is this needed for gdb 9? If so, then perhaps it can land on the branch
This issue does exist even in GDB 8.3. Nevertheless, I have included
the test into the latest patch [1]. That patch [1] has addressed the
latest remarks [2] from Andrew and should be fine.
A good way to check if the issue also happens for GDB 9 is by running
the test in a GDB 9 branch. I don't have one ready now, but if you
want I can give it a try.
Cheers,
Shahab
[1]
https://sourceware.org/ml/gdb-patches/2020-02/msg00127.html
[2]
https://sourceware.org/ml/gdb-patches/2020-02/msg00126.html
> without a test. For trunk there's normally no particular rush to get
> things in, and I think it would be good to have the test at the same
> time.
>
> Tom
next prev parent reply other threads:[~2020-02-06 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:26 Shahab Vahedi
2020-01-22 16:24 ` Andrew Burgess
2020-01-22 16:42 ` Shahab Vahedi
2020-01-23 18:18 ` Tom Tromey
2020-02-06 13:19 ` Shahab Vahedi [this message]
2020-02-06 15:26 ` Shahab Vahedi
2020-01-24 17:05 ` [PATCH v2] " Shahab Vahedi
2020-01-31 10:34 ` [PING] " Shahab Vahedi
2020-02-06 12:12 ` Andrew Burgess
2020-02-06 14:25 ` Andrew Burgess
2020-02-06 13:07 ` [PATCH v3] " Shahab Vahedi
2020-02-06 15:25 ` [PATCH v4] " Shahab Vahedi
2020-02-06 16:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206131932.GA1290@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=claziss@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox