From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Shahab Vahedi <shahab@synopsys.com>,
Tom Tromey <tom@tromey.com>,
Claudiu Zissulescu <claziss@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH] gdb: Catch exceptions if the source file is not found
Date: Wed, 22 Jan 2020 16:42:00 -0000 [thread overview]
Message-ID: <20200122163217.GA3311@gmail.com> (raw)
In-Reply-To: <20200122154901.GK3865@embecosm.com>
On Wed, Jan 22, 2020 at 03:49:01PM +0000, Andrew Burgess wrote:
>
> Would it be possible to create a version of this test (or similar)
> within gdb.tui/ so this fix would be protected in the future?
>
This is reproducible on an x86_64 host/target as well. These are
the necessary step that I have to automate by a test:
$ cat > file1.c <<EOF
extern int func2(int);
int main()
{
int a = 4;
return func2(a);
}
EOF
$ cat > file2.c <<EOF
int func2(int x)
{
x <<= 1;
return x+5;
}
EOF
$ gcc -g file1.c file2.c -o test
$ mv file1.c file1.c.moved
$ gdb -tui test.c
(gdb) start
(gdb) next
(gdb) step
at this point we should see func2 in source window.
It is just a matter of time for me to write my _first_ test.
If the changes are OK, I will submit the test in a separate
patch if you don't mind. I just don't want this fix fall
through the cracks as apparently it did once according to
Tom.
Cheers,
Shahab
next prev parent reply other threads:[~2020-01-22 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:26 Shahab Vahedi
2020-01-22 16:24 ` Andrew Burgess
2020-01-22 16:42 ` Shahab Vahedi [this message]
2020-01-23 18:18 ` Tom Tromey
2020-02-06 13:19 ` Shahab Vahedi
2020-02-06 15:26 ` Shahab Vahedi
2020-01-24 17:05 ` [PATCH v2] " Shahab Vahedi
2020-01-31 10:34 ` [PING] " Shahab Vahedi
2020-02-06 12:12 ` Andrew Burgess
2020-02-06 14:25 ` Andrew Burgess
2020-02-06 13:07 ` [PATCH v3] " Shahab Vahedi
2020-02-06 15:25 ` [PATCH v4] " Shahab Vahedi
2020-02-06 16:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122163217.GA3311@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=claziss@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox