From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65357 invoked by alias); 6 Feb 2020 13:19:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65349 invoked by uid 89); 6 Feb 2020 13:19:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*RU:gmail.com, HX-Spam-Relays-External:gmail.com, H*r:gmail.com, UD:msg00127.html X-HELO: mail-lf1-f67.google.com Received: from mail-lf1-f67.google.com (HELO mail-lf1-f67.google.com) (209.85.167.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2020 13:19:39 +0000 Received: by mail-lf1-f67.google.com with SMTP id z18so4083032lfe.2 for ; Thu, 06 Feb 2020 05:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-description:content-disposition:in-reply-to; bh=cMT9yGIXNDBfFwp0f+cjtBW+Gde6mMwpqtWk3BKY1Aw=; b=deG9VgrPdjhOiapLICiX6gyv3UqOTLIaD1q13svWlPYtXr/0K3Oq51V4T3gCt7qocF iFtrbR//cKoeLstJEgvTjHWcF1JLmFN3EXH9LZgOjXGhrtP0M1TpJ3Hwn1axjkeQCo5N ceEps3jahoBYjITBqUxnrA7hH1sUVYvKRMyqTfDMGmLbxusxFihuVOK4vqqHL9VRu7zg 7XbequENtOzyjjRloKDULYSRpomvK1NBG77pX9pWZM7AFBrzJ/Nt3O9340l9mKOHUbmW 96eP4fMXZpbSZOqL3gLEHPu9UUY3GLk2L65uQRXAEQwybt066+DB8/AjlU7vum6pNQA4 mEag== Return-Path: Received: from gmail.com ([2a03:1b20:6:f011::2d]) by smtp.gmail.com with ESMTPSA id p136sm1292406lfa.8.2020.02.06.05.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 05:19:35 -0800 (PST) Date: Thu, 06 Feb 2020 13:19:00 -0000 From: Shahab Vahedi To: Tom Tromey Cc: Andrew Burgess , gdb-patches@sourceware.org, Shahab Vahedi , Claudiu Zissulescu , Francois Bedard Subject: Re: [PATCH] gdb: Catch exceptions if the source file is not found Message-ID: <20200206131932.GA1290@gmail.com> References: <20200122140818.84308-1-shahab.vahedi@gmail.com> <20200122154901.GK3865@embecosm.com> <20200122163217.GA3311@gmail.com> <87lfpyxcp3.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: gdb9_issue_answer Content-Disposition: inline In-Reply-To: <87lfpyxcp3.fsf@tromey.com> X-SW-Source: 2020-02/txt/msg00128.txt.bz2 Hi Tom, On Thu, Jan 23, 2020 at 11:14:16AM -0700, Tom Tromey wrote: > >>>>> "Shahab" == Shahab Vahedi writes: > > Shahab> It is just a matter of time for me to write my _first_ test. > Shahab> If the changes are OK, I will submit the test in a separate > Shahab> patch if you don't mind. I just don't want this fix fall > Shahab> through the cracks as apparently it did once according to > Shahab> Tom. > > Is this needed for gdb 9? If so, then perhaps it can land on the branch This issue does exist even in GDB 8.3. Nevertheless, I have included the test into the latest patch [1]. That patch [1] has addressed the latest remarks [2] from Andrew and should be fine. A good way to check if the issue also happens for GDB 9 is by running the test in a GDB 9 branch. I don't have one ready now, but if you want I can give it a try. Cheers, Shahab [1] https://sourceware.org/ml/gdb-patches/2020-02/msg00127.html [2] https://sourceware.org/ml/gdb-patches/2020-02/msg00126.html > without a test. For trunk there's normally no particular rush to get > things in, and I think it would be good to have the test at the same > time. > > Tom