Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [review] Document m68k floating point feature correspondence
@ 2019-10-24 16:36 Tom Tromey (Code Review)
  2019-10-25 20:57 ` Luis Machado (Code Review)
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-24 16:36 UTC (permalink / raw)
  To: gdb-patches

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/281
......................................................................

Document m68k floating point feature correspondence

From what I can tell, The m68k floating point target feature should
apparently always be called "org.gnu.gdb.coldfire.fp" -- even when the
primary feature is not "coldfire", because m68k_gdbarch_init only
checks for this feature when assigning register numbers.

However, the floating point registers are expected to match what gdb
thinks are the register sizes for the primary feature.  For example,
if the main feature is "coldfire", then the floating point registers
should be 64 bits.

See this note for some an instance of this confusion:

    https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg04564.html

This patch documents the oddity.

Let me know what you think.  An alternate approach here might be to
make gdb adapt to the register sizes as actually reported.  I'm not
sure if this makes sense or not.

gdb/doc/ChangeLog
2019-10-24  Tom Tromey  <tromey@adacore.com>

	* gdb.texinfo (M68K Features): Document floating-point feature
	correspondence.

Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f
---
M gdb/doc/ChangeLog
M gdb/doc/gdb.texinfo
2 files changed, 11 insertions(+), 0 deletions(-)



diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 0d0d905..2b80699 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-24  Tom Tromey  <tromey@adacore.com>
+
+	* gdb.texinfo (M68K Features): Document floating-point feature
+	correspondence.
+
 2019-10-23  Tom Tromey  <tom@tromey.com>
 
 	* Makefile.in (READLINE_DIR): Update.
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 1208e4f..1fbf349 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -44346,6 +44346,12 @@
 This feature is optional.  If present, it should contain registers
 @samp{fp0} through @samp{fp7}, @samp{fpcontrol}, @samp{fpstatus} and
 @samp{fpiaddr}.
+
+Note that, despite the fact that this feature's name says
+@samp{coldfire}, it is used to describe any floating point registers.
+The size of the registers must match the main m68k flavor; so, for
+example, if the primary feature is reported as @samp{coldfire}, then
+64-bit floating point registers are required.
 @end table
 
 @node NDS32 Features

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f
Gerrit-Change-Number: 281
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-26 21:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 16:36 [review] Document m68k floating point feature correspondence Tom Tromey (Code Review)
2019-10-25 20:57 ` Luis Machado (Code Review)
2019-10-25 21:11 ` Tom Tromey (Code Review)
2019-11-21 19:45 ` Tom Tromey (Code Review)
2019-12-04 22:22 ` Tom Tromey
2020-01-24 18:25   ` Ping (Was: [review] Document m68k floating point feature correspondence) Tom Tromey
2020-01-24 21:22     ` Eli Zaretskii
2020-01-26 21:51 ` [pushed] Document m68k floating point feature correspondence Sourceware to Gerrit sync (Code Review)
2020-01-26 23:39 ` Sourceware to Gerrit sync (Code Review)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox