From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>
Subject: [review] Document m68k floating point feature correspondence
Date: Fri, 25 Oct 2019 21:11:00 -0000 [thread overview]
Message-ID: <20191025211113.EE58A204C9@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571934987000.I4cd86acbe3449a29ce38327524c508c206b25b8f@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/281
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> It is a bit confusing. Was coldfire the only target supporting Floating Point registers at the time?
Nope! I don't really know the history here. Internally we discussed
maybe supporting an "m68k.fp" feature, but in the end decided it wasn't
worth the effort, since older versions of gdb would not support this anyway.
> I happened to noticed that we only have coldfire.core in the XML description. Are we lacking a coldfire.fp XML in GDB? Is it only provided by non-GDB stubs?
Yeah, I don't know why gdb doesn't have other XML descriptions for m68k.
In this case the "coldfire.fp" feature is coming from an XML description
that qemu supplies.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f
Gerrit-Change-Number: 281
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 21:11:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-25 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 16:36 Tom Tromey (Code Review)
2019-10-25 20:57 ` Luis Machado (Code Review)
2019-10-25 21:11 ` Tom Tromey (Code Review) [this message]
2019-11-21 19:45 ` Tom Tromey (Code Review)
2019-12-04 22:22 ` Tom Tromey
2020-01-24 18:25 ` Ping (Was: [review] Document m68k floating point feature correspondence) Tom Tromey
2020-01-24 21:22 ` Eli Zaretskii
2020-01-26 21:51 ` [pushed] Document m68k floating point feature correspondence Sourceware to Gerrit sync (Code Review)
2020-01-26 23:39 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025211113.EE58A204C9@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox