From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
Date: Sun, 12 Jan 2020 08:13:00 -0000 [thread overview]
Message-ID: <20200112070646.GA24158@adacore.com> (raw)
In-Reply-To: <87d0bqexxj.fsf@tromey.com>
> I read through the series.
>
> I think this warning would be good to have, because it can help detect
> bugs.
A small bonus is that this warning should also help us detect functions
that could be declared static. Not a huge deal in terms of code
correctness, but a valuable piece of information, when one is
reading through the code...
> It's maybe mildly unfortunate that we have to have the first
> patch, but at the same time it's not that much noise in the end -- just
> an extra line (typically) near the end of a file. The other patches all
> seem desirable on their own terms.
>
> So, I think you should check it in.
+1
--
Joel
next prev parent reply other threads:[~2020-01-12 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:00 Simon Marchi
2020-01-10 22:00 ` [PATCH v2 3/7] gdbserver: include hostio.h in hostio-errno.c Simon Marchi
2020-01-10 22:00 ` [PATCH v2 4/7] gdbserver: include gdbsupport/common-inferior.h in inferiors.c Simon Marchi
2020-01-10 22:00 ` [PATCH v2 2/7] gdb: add declaration to Python init function Simon Marchi
2020-01-10 22:00 ` [PATCH v2 7/7] Enable -Wmissing-declarations diagnostic Simon Marchi
2020-01-11 3:33 ` Simon Marchi
2020-01-10 22:01 ` [PATCH v2 1/7] gdb: add back declarations for _initialize functions Simon Marchi
2020-01-11 3:32 ` Simon Marchi
2020-01-10 22:09 ` [PATCH v2 5/7] gdbserver: make some functions static in linux-x86-low.c Simon Marchi
2020-01-10 22:09 ` [PATCH v2 6/7] gdbserver: set IP_AGENT_EXPORT_FUNC to static when not building IPA, add declarations Simon Marchi
2020-01-11 18:11 ` [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic Tom Tromey
2020-01-11 17:29 ` Tom Tromey
2020-01-12 7:06 ` Simon Marchi
2020-01-13 19:19 ` Simon Marchi
2020-01-12 8:13 ` Joel Brobecker [this message]
2020-01-12 20:23 ` Simon Marchi
2020-01-13 17:42 ` Tom Tromey
2020-01-13 19:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200112070646.GA24158@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox