From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH v2 2/7] gdb: add declaration to Python init function
Date: Fri, 10 Jan 2020 22:00:00 -0000 [thread overview]
Message-ID: <20200110220027.26450-3-simon.marchi@efficios.com> (raw)
In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com>
When I try to enable -Wmissing-declarations, I get this error:
CXX python/python.o
/home/smarchi/src/binutils-gdb/gdb/python/python.c: In function ‘PyObject* init__gdb_module()’:
/home/smarchi/src/binutils-gdb/gdb/python/python.c:1582:1: error: no previous declaration for ‘PyObject* init__gdb_module()’ [-Werror=missing-declarations]
init__gdb_module (void)
^~~~~~~~~~~~~~~~
Prevent it by providing a declaration just before the definition.
gdb/ChangeLog:
* python/python.c (init__gdb_module): Add declaration.
Change-Id: I394bc691b7db624708cc4cb2cda28a56ab85a82b
---
gdb/python/python.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index f7aadb1633c8..e0c05f1d0689 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1555,6 +1555,7 @@ finalize_python (void *ignore)
/* This is called via the PyImport_AppendInittab mechanism called
during initialization, to make the built-in _gdb module known to
Python. */
+PyMODINIT_FUNC init__gdb_module (void);
PyMODINIT_FUNC
init__gdb_module (void)
{
--
2.24.1
next prev parent reply other threads:[~2020-01-10 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:00 [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic Simon Marchi
2020-01-10 22:00 ` [PATCH v2 7/7] " Simon Marchi
2020-01-11 3:33 ` Simon Marchi
2020-01-10 22:00 ` Simon Marchi [this message]
2020-01-10 22:00 ` [PATCH v2 3/7] gdbserver: include hostio.h in hostio-errno.c Simon Marchi
2020-01-10 22:00 ` [PATCH v2 4/7] gdbserver: include gdbsupport/common-inferior.h in inferiors.c Simon Marchi
2020-01-10 22:01 ` [PATCH v2 1/7] gdb: add back declarations for _initialize functions Simon Marchi
2020-01-11 3:32 ` Simon Marchi
2020-01-10 22:09 ` [PATCH v2 6/7] gdbserver: set IP_AGENT_EXPORT_FUNC to static when not building IPA, add declarations Simon Marchi
2020-01-10 22:09 ` [PATCH v2 5/7] gdbserver: make some functions static in linux-x86-low.c Simon Marchi
2020-01-11 18:11 ` [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic Tom Tromey
2020-01-11 17:29 ` Tom Tromey
2020-01-12 7:06 ` Simon Marchi
2020-01-13 19:19 ` Simon Marchi
2020-01-12 8:13 ` Joel Brobecker
2020-01-12 20:23 ` Simon Marchi
2020-01-13 17:42 ` Tom Tromey
2020-01-13 19:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110220027.26450-3-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox