From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH v2 7/7] Enable -Wmissing-declarations diagnostic
Date: Fri, 10 Jan 2020 22:00:00 -0000 [thread overview]
Message-ID: <20200110220027.26450-8-simon.marchi@efficios.com> (raw)
In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com>
Now that most warnings of this kind are fixed, we can enable
-Wmissing-declarations. I say "most", because it is likely that there
are some more in some configurations I am not able to build, but they
should be pretty easy to fix.
gdb/ChangeLog:
* warning.m4: Add -Wmissing-declarations to build_warnings.
* configure: Re-generate.
Change-Id: Iae9b59f22eb5dd1965d09f34c5c9e212cddf67ba
---
gdb/configure | 3 ++-
gdb/gdbserver/configure | 3 ++-
gdb/warning.m4 | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index b572d414ca51..aa53c097ca8f 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -16105,7 +16105,8 @@ build_warnings="-Wall -Wpointer-arith \
-Wshadow=local \
-Wdeprecated-copy \
-Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
case "${host}" in
*-*-mingw32*)
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 4de751b44915..f70b3d552156 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -8094,7 +8094,8 @@ build_warnings="-Wall -Wpointer-arith \
-Wshadow=local \
-Wdeprecated-copy \
-Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
case "${host}" in
*-*-mingw32*)
diff --git a/gdb/warning.m4 b/gdb/warning.m4
index 00bcdfa7ea50..e2b8a43ddbd5 100644
--- a/gdb/warning.m4
+++ b/gdb/warning.m4
@@ -49,7 +49,8 @@ build_warnings="-Wall -Wpointer-arith \
-Wshadow=local \
-Wdeprecated-copy \
-Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
case "${host}" in
*-*-mingw32*)
--
2.24.1
next prev parent reply other threads:[~2020-01-10 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:00 [PATCH v2 0/7] " Simon Marchi
2020-01-10 22:00 ` [PATCH v2 3/7] gdbserver: include hostio.h in hostio-errno.c Simon Marchi
2020-01-10 22:00 ` [PATCH v2 4/7] gdbserver: include gdbsupport/common-inferior.h in inferiors.c Simon Marchi
2020-01-10 22:00 ` [PATCH v2 2/7] gdb: add declaration to Python init function Simon Marchi
2020-01-10 22:00 ` Simon Marchi [this message]
2020-01-11 3:33 ` [PATCH v2 7/7] Enable -Wmissing-declarations diagnostic Simon Marchi
2020-01-10 22:01 ` [PATCH v2 1/7] gdb: add back declarations for _initialize functions Simon Marchi
2020-01-11 3:32 ` Simon Marchi
2020-01-10 22:09 ` [PATCH v2 5/7] gdbserver: make some functions static in linux-x86-low.c Simon Marchi
2020-01-10 22:09 ` [PATCH v2 6/7] gdbserver: set IP_AGENT_EXPORT_FUNC to static when not building IPA, add declarations Simon Marchi
2020-01-11 18:11 ` [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic Tom Tromey
2020-01-11 17:29 ` Tom Tromey
2020-01-12 7:06 ` Simon Marchi
2020-01-13 19:19 ` Simon Marchi
2020-01-12 8:13 ` Joel Brobecker
2020-01-12 20:23 ` Simon Marchi
2020-01-13 17:42 ` Tom Tromey
2020-01-13 19:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110220027.26450-8-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox