[review v2] Fix unused function error

["Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753
......................................................................


Patch Set 2:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,20 @@ 
| +Parent:     1d61b032 (Remove more shifts for sign/zero extension)
| +Author:     Luis Machado <luis.machado@linaro.org>
| +AuthorDate: 2019-12-11 11:55:49 -0300
| +Commit:     Luis Machado <luis.machado@linaro.org>
| +CommitDate: 2019-12-11 12:16:22 -0300
| +
| +Fix unused function error
| +
| +Attempting to build GDB in Ubuntu 18.04.3 on x86_64, i ran into warnings
| +that caused the build to fail. For some reason the diagnostics macros don't
| +work for my case, but ATTRIBUTE_UNUSED does.

PS2, Line 11:

It looks like this:

binutils-gdb/gdb/gdbsupport/safe-strerror.c:44:1: error: ‘char*
select_strerror_r(char*, char*)’ defined but not used [-Werror=unused-
function]  select_strerror_r (char *res, char *)

I reported a GCC version of 7.4.0, but in reality the box runs GCC
5.4.0.

As for the DIAGNOSTIC_IGNORE_UNUSED_FUNCTION macro, I gave this a try
and it seems the macros do get expanded, but they still have no effect
on the warning.

I replaced the macros with the pragmas to make sure. Still doesn't
work.

| +
| +The compiler version is gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0.
| +
| +gdb/ChangeLog:
| +
| +2019-12-11  Luis Machado  <luis.machado@linaro.org>
| +
| +	* gdb/gdbsupport/safe-strerror.c: Remove diagnostics.h
| +	(select_strerror_r): Use ATTRIBUTED_UNUSED instead of the diagnostics

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749
Gerrit-Change-Number: 753
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 17:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment