From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43185 invoked by alias); 11 Dec 2019 17:05:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43166 invoked by uid 89); 11 Dec 2019 17:05:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 17:05:16 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 9F9B720172; Wed, 11 Dec 2019 12:05:14 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 52A05202EB; Wed, 11 Dec 2019 12:05:13 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DCC9720AF6; Wed, 11 Dec 2019 12:05:12 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 11 Dec 2019 17:05:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Fix unused function error X-Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 X-Gerrit-Change-Number: 753 X-Gerrit-ChangeURL: X-Gerrit-Commit: eaaba2d48c28ad2547ead1aa83176b6160ed4b2e In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Dec 2019 12:05:12 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191211170512.DCC9720AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00419.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753 ...................................................................... Patch Set 2: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,20 @@ | +Parent: 1d61b032 (Remove more shifts for sign/zero extension) | +Author: Luis Machado | +AuthorDate: 2019-12-11 11:55:49 -0300 | +Commit: Luis Machado | +CommitDate: 2019-12-11 12:16:22 -0300 | + | +Fix unused function error | + | +Attempting to build GDB in Ubuntu 18.04.3 on x86_64, i ran into warnings | +that caused the build to fail. For some reason the diagnostics macros don't | +work for my case, but ATTRIBUTE_UNUSED does. PS2, Line 11: It looks like this: binutils-gdb/gdb/gdbsupport/safe-strerror.c:44:1: error: ‘char* select_strerror_r(char*, char*)’ defined but not used [-Werror=unused- function] select_strerror_r (char *res, char *) I reported a GCC version of 7.4.0, but in reality the box runs GCC 5.4.0. As for the DIAGNOSTIC_IGNORE_UNUSED_FUNCTION macro, I gave this a try and it seems the macros do get expanded, but they still have no effect on the warning. I replaced the macros with the pragmas to make sure. Still doesn't work. | + | +The compiler version is gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0. | + | +gdb/ChangeLog: | + | +2019-12-11 Luis Machado | + | + * gdb/gdbsupport/safe-strerror.c: Remove diagnostics.h | + (select_strerror_r): Use ATTRIBUTED_UNUSED instead of the diagnostics -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 Gerrit-Change-Number: 753 Gerrit-PatchSet: 2 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Wed, 11 Dec 2019 17:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment