From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review v6] Fix unused function error
Date: Thu, 12 Dec 2019 11:20:00 -0000 [thread overview]
Message-ID: <20191212111956.1C73720AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1576076440000.Iad6123d61d76d111e3ef8d24aa8c60112304c749@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753
......................................................................
Patch Set 6: Code-Review+2
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749
Gerrit-Change-Number: 753
Gerrit-PatchSet: 6
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 11:19:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-12-12 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:00 [review] " Luis Machado (Code Review)
2019-12-11 15:17 ` [review v2] " Luis Machado (Code Review)
2019-12-11 16:05 ` Pedro Alves (Code Review)
2019-12-11 17:05 ` Luis Machado (Code Review)
2019-12-11 17:07 ` [review v3] " Luis Machado (Code Review)
2019-12-11 17:11 ` [review v4] " Luis Machado (Code Review)
2019-12-11 17:17 ` [review v3] " Pedro Alves (Code Review)
2019-12-11 17:26 ` [review v4] " Christian Biesinger (Code Review)
2019-12-11 17:58 ` Luis Machado (Code Review)
2019-12-11 18:03 ` Pedro Alves (Code Review)
2019-12-11 18:19 ` Luis Machado (Code Review)
2019-12-11 18:23 ` Pedro Alves (Code Review)
2019-12-11 18:25 ` Pedro Alves (Code Review)
2019-12-11 19:28 ` [review v5] " Luis Machado (Code Review)
2019-12-11 19:54 ` Pedro Alves (Code Review)
2019-12-12 11:14 ` [review v6] " Luis Machado (Code Review)
2019-12-12 11:15 ` Luis Machado (Code Review)
2019-12-12 11:20 ` Pedro Alves (Code Review) [this message]
2019-12-12 12:13 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-12 12:13 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212111956.1C73720AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox