[review v2] Remove gdbarch_bits_big_endian

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

| --- gdb/gdbtypes.h
| +++ gdb/gdbtypes.h
| @@ -545,16 +545,15 @@ };
|  
|  union type_owner
|  {
|    struct objfile *objfile;
|    struct gdbarch *gdbarch;
|  };
|  
|  union field_location
|  {
|    /* * Position of this field, counting in bits from start of

PS1, Line 554:

Ah ok, I have always seen /** (without space between the asterisks)
for Doxygen.

| -     containing structure.  For gdbarch_bits_big_endian=1
| -     targets, it is the bit offset to the MSB.  For
| -     gdbarch_bits_big_endian=0 targets, it is the bit offset to
| -     the LSB.  */
| +     containing structure.  For big-endian targets, it is the bit
| +     offset to the MSB.  For little-endian targets, it is the bit
| +     offset to the LSB.  */
|  
|    LONGEST bitpos;

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018
Gerrit-Change-Number: 729
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 15:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment