From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69670 invoked by alias); 4 Dec 2019 15:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69643 invoked by uid 89); 4 Dec 2019 15:35:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 15:35:36 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7D8412039A; Wed, 4 Dec 2019 10:35:34 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 44A3B201F1; Wed, 4 Dec 2019 10:35:29 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2999E2816F; Wed, 4 Dec 2019 10:35:29 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 04 Dec 2019 15:35:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Remove gdbarch_bits_big_endian X-Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 X-Gerrit-Change-Number: 729 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6952a2e0c4accbab2a620c1eab10db030f91bf24 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 4 Dec 2019 10:35:28 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191204153529.2999E2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00135.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) | --- gdb/gdbtypes.h | +++ gdb/gdbtypes.h | @@ -545,16 +545,15 @@ }; | | union type_owner | { | struct objfile *objfile; | struct gdbarch *gdbarch; | }; | | union field_location | { | /* * Position of this field, counting in bits from start of PS1, Line 554: Ah ok, I have always seen /** (without space between the asterisks) for Doxygen. | - containing structure. For gdbarch_bits_big_endian=1 | - targets, it is the bit offset to the MSB. For | - gdbarch_bits_big_endian=0 targets, it is the bit offset to | - the LSB. */ | + containing structure. For big-endian targets, it is the bit | + offset to the MSB. For little-endian targets, it is the bit | + offset to the LSB. */ | | LONGEST bitpos; -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 Gerrit-Change-Number: 729 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Wed, 04 Dec 2019 15:35:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tom Tromey Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment