[review] Remove gdbarch_bits_big_endian

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729
......................................................................


Patch Set 1:

(2 comments)

| --- gdb/dwarf2loc.c
| +++ gdb/dwarf2loc.c
| @@ -1573,18 +1573,17 @@ rw_pieced_value (struct value *v, struct value *from)
|    LONGEST offset = 0, max_offset;
|    ULONGEST bits_to_skip;
|    gdb_byte *v_contents;
|    const gdb_byte *from_contents;
|    struct piece_closure *c
|      = (struct piece_closure *) value_computed_closure (v);
|    gdb::byte_vector buffer;
| -  int bits_big_endian
| -    = gdbarch_bits_big_endian (get_type_arch (value_type (v)));
| +  int bits_big_endian = type_byte_order (value_type (v)) == BFD_ENDIAN_BIG;

PS1, Line 1580:

It could be a good opportunity to change all these int to bool, in the
lines that you touched.

|  
|    if (from != NULL)
|      {
|        from_contents = value_contents (from);
|        v_contents = NULL;
|      }
|    else
|      {
|        if (value_type (v) != value_enclosing_type (v))
| --- gdb/gdbtypes.h
| +++ gdb/gdbtypes.h
| @@ -545,16 +545,15 @@ };
|  
|  union type_owner
|  {
|    struct objfile *objfile;
|    struct gdbarch *gdbarch;
|  };
|  
|  union field_location
|  {
|    /* * Position of this field, counting in bits from start of

PS1, Line 554:

Could you remove this extra asterisk while at it?

| -     containing structure.  For gdbarch_bits_big_endian=1
| -     targets, it is the bit offset to the MSB.  For
| -     gdbarch_bits_big_endian=0 targets, it is the bit offset to
| -     the LSB.  */
| +     containing structure.  For big-endian targets, it is the bit
| +     offset to the MSB.  For little-endian targets, it is the bit
| +     offset to the LSB.  */
|  
|    LONGEST bitpos;

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018
Gerrit-Change-Number: 729
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 22:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment