From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85249 invoked by alias); 27 Nov 2019 22:09:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85234 invoked by uid 89); 27 Nov 2019 22:09:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 22:09:01 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7ED7E203AC; Wed, 27 Nov 2019 17:08:59 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 7205620362; Wed, 27 Nov 2019 17:08:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5DACF20AF6; Wed, 27 Nov 2019 17:08:58 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 22:09:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove gdbarch_bits_big_endian X-Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 X-Gerrit-Change-Number: 729 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d43bc957b28f3a4fd72d675ac463f7a0214dd6a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 17:08:57 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127220858.5DACF20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01074.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729 ...................................................................... Patch Set 1: (2 comments) | --- gdb/dwarf2loc.c | +++ gdb/dwarf2loc.c | @@ -1573,18 +1573,17 @@ rw_pieced_value (struct value *v, struct value *from) | LONGEST offset = 0, max_offset; | ULONGEST bits_to_skip; | gdb_byte *v_contents; | const gdb_byte *from_contents; | struct piece_closure *c | = (struct piece_closure *) value_computed_closure (v); | gdb::byte_vector buffer; | - int bits_big_endian | - = gdbarch_bits_big_endian (get_type_arch (value_type (v))); | + int bits_big_endian = type_byte_order (value_type (v)) == BFD_ENDIAN_BIG; PS1, Line 1580: It could be a good opportunity to change all these int to bool, in the lines that you touched. | | if (from != NULL) | { | from_contents = value_contents (from); | v_contents = NULL; | } | else | { | if (value_type (v) != value_enclosing_type (v)) | --- gdb/gdbtypes.h | +++ gdb/gdbtypes.h | @@ -545,16 +545,15 @@ }; | | union type_owner | { | struct objfile *objfile; | struct gdbarch *gdbarch; | }; | | union field_location | { | /* * Position of this field, counting in bits from start of PS1, Line 554: Could you remove this extra asterisk while at it? | - containing structure. For gdbarch_bits_big_endian=1 | - targets, it is the bit offset to the MSB. For | - gdbarch_bits_big_endian=0 targets, it is the bit offset to | - the LSB. */ | + containing structure. For big-endian targets, it is the bit | + offset to the MSB. For little-endian targets, it is the bit | + offset to the LSB. */ | | LONGEST bitpos; -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 Gerrit-Change-Number: 729 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 22:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment