[review v2] gdb: Split global symbol search into separate functions

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/738
......................................................................


Patch Set 2:

(1 comment)

I left one comment, but otherwise LGTM.

| --- gdb/symtab.c
| +++ gdb/symtab.c
| @@ -4435,0 +4591,19 @@ global_symbol_searcher::add_matching_symbols
| +				  || treg_matches_sym_type_name (*treg,
| +								 sym)))
| +			  || (kind == TYPES_DOMAIN
| +			      && SYMBOL_CLASS (sym) == LOC_TYPEDEF
| +			      && SYMBOL_DOMAIN (sym) != MODULE_DOMAIN)
| +			  || (kind == MODULES_DOMAIN
| +			      && SYMBOL_DOMAIN (sym) == MODULE_DOMAIN
| +			      && SYMBOL_LINE (sym) != 0))))
| +		{
| +		  /* Match, insert if not already in the results.  */

PS2, Line 4600:

This part is not accurate for this patch, should be added by the
following patch, I guess.

| +		  results->emplace_back (block, sym);
| +		}
| +	    }
| +	}
| +    }
| +}
| +
| +/* See symtab.h.  */
| +

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I06b26920f35c268f7a38d8203dc2c2813aa501c6
Gerrit-Change-Number: 738
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 03 Dec 2019 02:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment