[review] gdb: Split global symbol search into separate functions

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/738
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/symtab.c
| +++ gdb/symtab.c
| @@ -4597,17 +4714,4 @@ global_symbol_searcher::search () const
| -			     .symbol == NULL))
| -			found_misc = 1;
| -		    }
| -		}
| -	    }
| -	}
| -    }
| -
| +  bool found_msymbol = false;
| +  std::set<symbol_search> result_set;

PS1, Line 4715:

Maybe a bit pedantic, but introducing the set in this patch does
possibly change the behavior, doesn't it?  Wouldn't it be better to
keep appending to a vector, as before, and then replace the vector
with a set in the following patch, with a justification of why that
change is needed?

|    for (objfile *objfile : current_program_space->objfiles ())
|      {
| -      for (compunit_symtab *cust : objfile->compunits ())
| -	{
| -	  bv = COMPUNIT_BLOCKVECTOR (cust);
| -	  for (i = GLOBAL_BLOCK; i <= STATIC_BLOCK; i++)
| -	    {
| -	      b = BLOCKVECTOR_BLOCK (bv, i);
| -	      ALL_BLOCK_SYMBOLS (b, iter, sym)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I06b26920f35c268f7a38d8203dc2c2813aa501c6
Gerrit-Change-Number: 738
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 02 Dec 2019 19:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment