From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3757 invoked by alias); 3 Dec 2019 02:18:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3707 invoked by uid 89); 3 Dec 2019 02:18:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 02:18:57 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8357B20484; Mon, 2 Dec 2019 21:18:54 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id B47F320362; Mon, 2 Dec 2019 21:18:53 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id EC63C2816F; Mon, 2 Dec 2019 21:18:47 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Tue, 03 Dec 2019 02:18:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] gdb: Split global symbol search into separate functions X-Gerrit-Change-Id: I06b26920f35c268f7a38d8203dc2c2813aa501c6 X-Gerrit-Change-Number: 738 X-Gerrit-ChangeURL: X-Gerrit-Commit: ba13b67c696736942bfa591290dd370590174c1f In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 2 Dec 2019 21:18:43 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203021847.EC63C2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00075.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/738 ...................................................................... Patch Set 2: (1 comment) I left one comment, but otherwise LGTM. | --- gdb/symtab.c | +++ gdb/symtab.c | @@ -4435,0 +4591,19 @@ global_symbol_searcher::add_matching_symbols | + || treg_matches_sym_type_name (*treg, | + sym))) | + || (kind == TYPES_DOMAIN | + && SYMBOL_CLASS (sym) == LOC_TYPEDEF | + && SYMBOL_DOMAIN (sym) != MODULE_DOMAIN) | + || (kind == MODULES_DOMAIN | + && SYMBOL_DOMAIN (sym) == MODULE_DOMAIN | + && SYMBOL_LINE (sym) != 0)))) | + { | + /* Match, insert if not already in the results. */ PS2, Line 4600: This part is not accurate for this patch, should be added by the following patch, I guess. | + results->emplace_back (block, sym); | + } | + } | + } | + } | +} | + | +/* See symtab.h. */ | + -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I06b26920f35c268f7a38d8203dc2c2813aa501c6 Gerrit-Change-Number: 738 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 03 Dec 2019 02:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment