[review v3] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

> I've removed the use of 'rm -fr' from the patch and checked that this makes no difference to the test results even after multiple runs of the test with and without ctf support.  I just copied this code from elsewhere in the testsuite, there was no particular requirement for the removal of the old directory.
> 
> If everyone's happy I don't see any reason why this series couldn't be merged.

Thanks, this patch and its predecessors all LGTM.

| --- gdb/testsuite/gdb.base/whatis.exp
| +++ gdb/testsuite/gdb.base/whatis.exp
| @@ -586,0 +590,14 @@ if [compiler_supports_ctf_debug] {
| +    lappend specs {ctf {"additional_flags=-gt"}}
| +}
| +
| +# Setup and run the test for each debug format.
| +foreach testspec $specs {
| +    set prefix [lindex $testspec 0]
| +    set opts [lindex $testspec 1]
| +
| +    with_test_prefix $prefix {
| +	remote_exec host "rm -rf [standard_output_file ${prefix}]"

PS1, Line 599:

> Is this rm -rf necessary?  I'm always a bit hesitant to use them in scripts, since the consequences of making a mistake in the command can be quite dramatic.
> 
> This comment applies to the previous patch too.

Done.

| +	remote_exec host "mkdir -p [standard_output_file ${prefix}]"
| +	do_test $prefix $opts
| +    }
| +}

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51
Gerrit-Change-Number: 123
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 18 Nov 2019 18:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment