From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tromey@sourceware.org>
Subject: [review v3] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp
Date: Mon, 18 Nov 2019 18:06:00 -0000 [thread overview]
Message-ID: <20191118180603.841AD2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571177353000.I09e11c70f197b79d2b1e0ae8c86a21c622be6c51@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123
......................................................................
Patch Set 3:
> Patch Set 1: Code-Review+1
>
> (1 comment)
>
> Andrew, is there anything holding back this series? I noted a minor comment, but in general I think it's nice.
I've removed the use of 'rm -fr' from the patch and checked that this makes no difference to the test results even after multiple runs of the test with and without ctf support. I just copied this code from elsewhere in the testsuite, there was no particular requirement for the removal of the old directory.
If everyone's happy I don't see any reason why this series couldn't be merged.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51
Gerrit-Change-Number: 123
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 18 Nov 2019 18:06:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-18 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 22:09 [review] " Andrew Burgess (Code Review)
2019-10-18 18:20 ` Tom Tromey (Code Review)
2019-11-16 22:32 ` Simon Marchi (Code Review)
2019-11-18 17:54 ` [review v2] " Andrew Burgess (Code Review)
2019-11-18 17:57 ` [review v3] " Andrew Burgess (Code Review)
2019-11-18 18:06 ` Andrew Burgess (Code Review) [this message]
2019-11-18 18:47 ` Simon Marchi (Code Review)
2019-11-19 0:47 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-19 0:48 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118180603.841AD2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox