From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86184 invoked by alias); 18 Nov 2019 18:06:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86131 invoked by uid 89); 18 Nov 2019 18:06:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=noted X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:06:06 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A70B920393; Mon, 18 Nov 2019 13:06:04 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9E6B020250; Mon, 18 Nov 2019 13:06:03 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 841AD2816F; Mon, 18 Nov 2019 13:06:03 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Mon, 18 Nov 2019 18:06:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp X-Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51 X-Gerrit-Change-Number: 123 X-Gerrit-ChangeURL: X-Gerrit-Commit: a0e4f200e83176e7413c93b8f1ffde5dfd878fe3 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 13:06:03 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118180603.841AD2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00534.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123 ...................................................................... Patch Set 3: > Patch Set 1: Code-Review+1 > > (1 comment) > > Andrew, is there anything holding back this series? I noted a minor comment, but in general I think it's nice. I've removed the use of 'rm -fr' from the patch and checked that this makes no difference to the test results even after multiple runs of the test with and without ctf support. I just copied this code from elsewhere in the testsuite, there was no particular requirement for the removal of the old directory. If everyone's happy I don't see any reason why this series couldn't be merged. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51 Gerrit-Change-Number: 123 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Mon, 18 Nov 2019 18:06:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment