From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127705 invoked by alias); 18 Nov 2019 18:47:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127690 invoked by uid 89); 18 Nov 2019 18:47:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:47:44 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 391FC203AC; Mon, 18 Nov 2019 13:47:43 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 30A5F20373; Mon, 18 Nov 2019 13:47:42 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C35502816F; Mon, 18 Nov 2019 13:47:41 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Mon, 18 Nov 2019 18:47:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp X-Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51 X-Gerrit-Change-Number: 123 X-Gerrit-ChangeURL: X-Gerrit-Commit: a0e4f200e83176e7413c93b8f1ffde5dfd878fe3 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 13:47:41 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118184741.C35502816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00538.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) > I've removed the use of 'rm -fr' from the patch and checked that this makes no difference to the test results even after multiple runs of the test with and without ctf support. I just copied this code from elsewhere in the testsuite, there was no particular requirement for the removal of the old directory. > > If everyone's happy I don't see any reason why this series couldn't be merged. Thanks, this patch and its predecessors all LGTM. | --- gdb/testsuite/gdb.base/whatis.exp | +++ gdb/testsuite/gdb.base/whatis.exp | @@ -586,0 +590,14 @@ if [compiler_supports_ctf_debug] { | + lappend specs {ctf {"additional_flags=-gt"}} | +} | + | +# Setup and run the test for each debug format. | +foreach testspec $specs { | + set prefix [lindex $testspec 0] | + set opts [lindex $testspec 1] | + | + with_test_prefix $prefix { | + remote_exec host "rm -rf [standard_output_file ${prefix}]" PS1, Line 599: > Is this rm -rf necessary? I'm always a bit hesitant to use them in scripts, since the consequences of making a mistake in the command can be quite dramatic. > > This comment applies to the previous patch too. Done. | + remote_exec host "mkdir -p [standard_output_file ${prefix}]" | + do_test $prefix $opts | + } | +} -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51 Gerrit-Change-Number: 123 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Mon, 18 Nov 2019 18:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment