[review] gdb: Convert frame_show_address to return a bool

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541
......................................................................


Patch Set 1:

(1 comment)

Thanks Andrew for letting me use you as a guinea pig for this change :).

> --- gdb/stack.c
> +++ gdb/stack.c
> @@ -247,18 +247,18 @@ static int last_displayed_sal_valid = 0;
>  static struct program_space *last_displayed_pspace = 0;
>  static CORE_ADDR last_displayed_addr = 0;
>  static struct symtab *last_displayed_symtab = 0;
>  static int last_displayed_line = 0;
>  \f
>  
>  /* See stack.h.  */
>  
> -int
> +bool

PS1, Line 255:

I think this is a really good change (take 5).

>  frame_show_address (struct frame_info *frame,
>  		    struct symtab_and_line sal)
>  {
>    /* If there is a line number, but no PC, then there is no location
>       information associated with this sal.  The only way that should
>       happen is for the call sites of inlined functions (SAL comes from
>       find_frame_sal).  Otherwise, we would have some PC range if the
>       SAL came from a line table.  */
>    if (sal.line != 0 && sal.pc == 0 && sal.end == 0)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f
Gerrit-Change-Number: 541
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Fri, 08 Nov 2019 16:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment