[review] gdb: Convert frame_show_address to return a bool

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

This is to test the new comment notification emails, but while at it, this change LGTM.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541/1/gdb/stack.c 
File gdb/stack.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541/1/gdb/stack.c@255 
PS1, Line 255: 
250 | static int last_displayed_line = 0;
251 | \f
252 | 
253 | /* See stack.h.  */
254 | 
255 > bool
256 | frame_show_address (struct frame_info *frame,
257 | 		    struct symtab_and_line sal)
258 | {
259 |   /* If there is a line number, but no PC, then there is no location
260 |      information associated with this sal.  The only way that should

I think this is a really good change.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f
Gerrit-Change-Number: 541
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Fri, 08 Nov 2019 16:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment