From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22201 invoked by alias); 8 Nov 2019 16:27:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22184 invoked by uid 89); 8 Nov 2019 16:27:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1343 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 16:27:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 893AC2058E; Fri, 8 Nov 2019 11:27:23 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3D3EC20322; Fri, 8 Nov 2019 11:27:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 13AEE25B28; Fri, 8 Nov 2019 11:27:22 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 08 Nov 2019 16:27:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Convert frame_show_address to return a bool X-Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f X-Gerrit-Change-Number: 541 X-Gerrit-ChangeURL: X-Gerrit-Commit: 15fd4ce2e03f60fbc58c933418a243ea238ab8ed In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 8 Nov 2019 11:27:21 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191108162722.13AEE25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00236.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) This is to test the new comment notification emails, but while at it, this change LGTM. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541/1/gdb/stack.c File gdb/stack.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541/1/gdb/stack.c@255 PS1, Line 255: 250 | static int last_displayed_line = 0; 251 | 252 | 253 | /* See stack.h. */ 254 | 255 > bool 256 | frame_show_address (struct frame_info *frame, 257 | struct symtab_and_line sal) 258 | { 259 | /* If there is a line number, but no PC, then there is no location 260 | information associated with this sal. The only way that should I think this is a really good change. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f Gerrit-Change-Number: 541 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Fri, 08 Nov 2019 16:27:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment