From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36407 invoked by alias); 8 Nov 2019 16:38:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36399 invoked by uid 89); 8 Nov 2019 16:38:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 16:38:50 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AD9D020AF8; Fri, 8 Nov 2019 11:38:48 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 7400820322; Fri, 8 Nov 2019 11:38:47 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 51E6625B28; Fri, 8 Nov 2019 11:38:47 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 08 Nov 2019 16:38:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Convert frame_show_address to return a bool X-Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f X-Gerrit-Change-Number: 541 X-Gerrit-ChangeURL: X-Gerrit-Commit: 15fd4ce2e03f60fbc58c933418a243ea238ab8ed In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 8 Nov 2019 11:38:46 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191108163847.51E6625B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00239.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541 ...................................................................... Patch Set 1: (1 comment) Thanks Andrew for letting me use you as a guinea pig for this change :). > --- gdb/stack.c > +++ gdb/stack.c > @@ -247,18 +247,18 @@ static int last_displayed_sal_valid = 0; > static struct program_space *last_displayed_pspace = 0; > static CORE_ADDR last_displayed_addr = 0; > static struct symtab *last_displayed_symtab = 0; > static int last_displayed_line = 0; > > > /* See stack.h. */ > > -int > +bool PS1, Line 255: I think this is a really good change (take 5). > frame_show_address (struct frame_info *frame, > struct symtab_and_line sal) > { > /* If there is a line number, but no PC, then there is no location > information associated with this sal. The only way that should > happen is for the call sites of inlined functions (SAL comes from > find_frame_sal). Otherwise, we would have some PC range if the > SAL came from a line table. */ > if (sal.line != 0 && sal.pc == 0 && sal.end == 0) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f Gerrit-Change-Number: 541 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Fri, 08 Nov 2019 16:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment