From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
Luis Machado <luis.machado@linaro.org>
Subject: [review] [RFC][gdb/contrib] Add words.sh script
Date: Tue, 05 Nov 2019 16:21:00 -0000 [thread overview]
Message-ID: <20191105162114.5D40A25B28@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571935190000.I7b119c9a4519cdbf62a3243d1df2927c80813e8b@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/282
......................................................................
Patch Set 1:
I'd suggest running shellcheck (https://www.shellcheck.net/) on it and fixing the few small warnings it gives.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b
Gerrit-Change-Number: 282
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 05 Nov 2019 16:21:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-05 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 16:39 Tom de Vries (Code Review)
2019-10-25 17:51 ` Luis Machado (Code Review)
2019-10-25 17:51 ` Luis Machado (Code Review)
2019-11-05 15:40 ` Tom Tromey (Code Review)
2019-11-05 16:21 ` Simon Marchi (Code Review) [this message]
2019-11-07 9:32 ` [review v2] [gdb/contrib] " Tom de Vries (Code Review)
2019-11-07 9:45 ` [review] " Tom de Vries (Code Review)
2019-11-07 9:46 ` [review v2] " Tom de Vries (Code Review)
2019-11-07 9:51 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-07 9:51 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105162114.5D40A25B28@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
--cc=tdevries@suse.de \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox