Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: [review] [RFC][gdb/contrib] Add words.sh script
Date: Fri, 25 Oct 2019 17:51:00 -0000	[thread overview]
Message-ID: <20191025175101.A6FE7204C9@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571935190000.I7b119c9a4519cdbf62a3243d1df2927c80813e8b@gnutoolchain-gerrit.osci.io>

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/282
......................................................................


Patch Set 1:

Thanks, this is pretty cool! I ran a few examples and it seems very useful.

I'd put your example of scanning all .[c|h] files into the script itself, so it is immediately obvious how to perform such action.

Something that i tried out of the box and that gave me a weird result was "./words --help". It listed words from awk i think, which is a bit odd. But since it is a basic script, it's not a big deal.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b
Gerrit-Change-Number: 282
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 17:51:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


  reply	other threads:[~2019-10-25 17:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:39 Tom de Vries (Code Review)
2019-10-25 17:51 ` Luis Machado (Code Review) [this message]
2019-10-25 17:51 ` Luis Machado (Code Review)
2019-11-05 15:40 ` Tom Tromey (Code Review)
2019-11-05 16:21 ` Simon Marchi (Code Review)
2019-11-07  9:32 ` [review v2] [gdb/contrib] " Tom de Vries (Code Review)
2019-11-07  9:45 ` [review] " Tom de Vries (Code Review)
2019-11-07  9:46 ` [review v2] " Tom de Vries (Code Review)
2019-11-07  9:51 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-07  9:51 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025175101.A6FE7204C9@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=gnutoolchain-gerrit@osci.io \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox