From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67241 invoked by alias); 25 Oct 2019 17:51:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67231 invoked by uid 89); 25 Oct 2019 17:51:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1046 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 17:51:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D8BE62104C; Fri, 25 Oct 2019 13:51:02 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C157120E5F; Fri, 25 Oct 2019 13:51:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A6FE7204C9; Fri, 25 Oct 2019 13:51:01 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Fri, 25 Oct 2019 17:51:00 -0000 From: "Luis Machado (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [RFC][gdb/contrib] Add words.sh script X-Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b X-Gerrit-Change-Number: 282 X-Gerrit-ChangeURL: X-Gerrit-Commit: d24c519ae276e163daf80d601cdb3c329e225c36 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 25 Oct 2019 13:51:01 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191025175101.A6FE7204C9@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00921.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/282 ...................................................................... Patch Set 1: Thanks, this is pretty cool! I ran a few examples and it seems very useful. I'd put your example of scanning all .[c|h] files into the script itself, so it is immediately obvious how to perform such action. Something that i tried out of the box and that gave me a weird result was "./words --help". It listed words from awk i think, which is a bit odd. But since it is a basic script, it's not a big deal. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b Gerrit-Change-Number: 282 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-CC: Luis Machado Gerrit-Comment-Date: Fri, 25 Oct 2019 17:51:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment