From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39994 invoked by alias); 5 Nov 2019 16:21:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39977 invoked by uid 89); 5 Nov 2019 16:21:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2019 16:21:17 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D10C32047F; Tue, 5 Nov 2019 11:21:15 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 825F7203A6; Tue, 5 Nov 2019 11:21:14 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5D40A25B28; Tue, 5 Nov 2019 11:21:14 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 05 Nov 2019 16:21:00 -0000 From: "Simon Marchi (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [RFC][gdb/contrib] Add words.sh script X-Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b X-Gerrit-Change-Number: 282 X-Gerrit-ChangeURL: X-Gerrit-Commit: d24c519ae276e163daf80d601cdb3c329e225c36 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 5 Nov 2019 11:21:14 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191105162114.5D40A25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00123.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/282 ...................................................................... Patch Set 1: I'd suggest running shellcheck (https://www.shellcheck.net/) on it and fixing the few small warnings it gives. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b Gerrit-Change-Number: 282 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 05 Nov 2019 16:21:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment