From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: [review v4] Add static_asserts for the sizes of space-critical structs
Date: Mon, 04 Nov 2019 17:56:00 -0000 [thread overview]
Message-ID: <20191104175635.088E725B28@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572028967000.Idd68320aa3e79ee7cc749019724636a58ce4b9c6@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306
......................................................................
Patch Set 4: Code-Review+2
Thank you. This looks good to me.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6
Gerrit-Change-Number: 306
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 04 Nov 2019 17:56:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-04 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 18:42 [review] " Christian Biesinger (Code Review)
2019-10-29 19:22 ` [review v2] " Tom Tromey (Code Review)
2019-11-04 17:43 ` [review v3] " Christian Biesinger (Code Review)
2019-11-04 17:44 ` [review v4] " Christian Biesinger (Code Review)
2019-11-04 17:56 ` Tom Tromey (Code Review) [this message]
2019-11-04 18:14 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-13 9:47 ` Szabolcs Nagy
2019-11-13 20:06 ` Christian Biesinger via gdb-patches
2019-11-04 18:14 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104175635.088E725B28@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox