[review v2] Add static_asserts for the sizes of space-critical structs

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I think these spots should maybe come with a short comment explaining
that the assert is just to make sure you don't change the size by
accident.  That way people changing the size on purpose will know
they can just update the assert.  WDYT?

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306/2/gdb/symtab.h 
File gdb/symtab.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306/2/gdb/symtab.h@1189 
PS2, Line 1189: 
1180 |   /* FIXME drow/2003-02-21: For the LOC_BLOCK case, it might be better
1181 |      to add a magic symbol to the block containing this information,
1182 |      or to have a generic debug info annotation slot for symbols.  */
1183 | 
1184 |   void *aux_value;
1185 | 
1186 |   struct symbol *hash_next;
1187 | };
1188 | 
1189 | gdb_static_assert ((sizeof (void *) == 8 && sizeof (symbol) == 72) ||

|| at the start of the next line.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6
Gerrit-Change-Number: 306
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Tue, 29 Oct 2019 19:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment