[review v3] Add static_asserts for the sizes of space-critical structs

["Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306
......................................................................


Uploaded patch set 3: Patch Set 2 was rebased.

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306/2/gdb/symtab.h 
File gdb/symtab.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306/2/gdb/symtab.h@1189 
PS2, Line 1189: 
1184 |   void *aux_value;
1185 | 
1186 |   struct symbol *hash_next;
1187 | };
1188 | 
1189 > gdb_static_assert ((sizeof (void *) == 8 && sizeof (symbol) == 72) ||
1190 | 		   (sizeof (void *) == 4 && sizeof (symbol) == 40));
1191 | 
1192 | /* Several lookup functions return both a symbol and the block in which the
1193 |    symbol is found.  This structure is used in these cases.  */
1194 | 

> || at the start of the next line.

Done



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6
Gerrit-Change-Number: 306
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 04 Nov 2019 17:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment