From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>
Subject: [review v5] Change some arguments to gdb::string_view instead of name+len
Date: Mon, 28 Oct 2019 19:02:00 -0000 [thread overview]
Message-ID: <20191028190201.CF36B20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571215766000.I2675c6865e0368f9c755a1081088a53aa54dda4c@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125
......................................................................
Patch Set 5:
OK, I've updated this patch slightly. With the new version of https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/222, this should be ready to check in. See the updated commit message in that patch for the resolution to the copy/nulltermination issue.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2675c6865e0368f9c755a1081088a53aa54dda4c
Gerrit-Change-Number: 125
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 19:02:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-28 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 8:49 [review] " Christian Biesinger (Code Review)
2019-10-16 12:39 ` Christian Biesinger (Code Review)
2019-10-19 22:06 ` [review v2] " Christian Biesinger (Code Review)
2019-10-22 22:14 ` [review v4] " Christian Biesinger (Code Review)
2019-10-25 17:55 ` Tom Tromey (Code Review)
2019-10-28 19:01 ` [review v5] " Christian Biesinger (Code Review)
2019-10-28 19:02 ` Christian Biesinger (Code Review) [this message]
2019-10-29 19:16 ` Tom Tromey (Code Review)
2019-10-29 19:28 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-29 19:28 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028190201.CF36B20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox