[review v4] Change some arguments to gdb::string_view instead of name+len

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125
......................................................................


Patch Set 4:

(1 comment)

Thank you for the patch.  I'm sorry about the delay on this.

I agree with Pedro when he wrote:

> My feeling is that one of the points of vocabulary types like string_view is
> that you replace documentation with rules or contracts enforced by, or
> encoded in the types.  To me, it feels like a bit of a hack or design issue that
> we switch to string_view while at the same time, find that we need to step
> outside its contract.

This particular bit of code (I added a comment below for those reading along)
has always been a bit fishy.  It's an attempt to micro-optimize in a maybe
unusual case.  I think it would be better to just drop this little optimization
in favor of copying here.  Perhaps in conjunction with your other patches,
this won't even be a bit hit.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125/4/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125/4/gdb/symtab.c@858 
PS4, Line 858:   /* Don't use string_view::operator[] because we are accessing beyond
             :      the size of the string_view, which is technically unsupported.  */
             :   if (l
This is the problem spot.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2675c6865e0368f9c755a1081088a53aa54dda4c
Gerrit-Change-Number: 125
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 17:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment