From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128125 invoked by alias); 28 Oct 2019 19:02:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127856 invoked by uid 89); 28 Oct 2019 19:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2019 19:02:05 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7389921171; Mon, 28 Oct 2019 15:02:03 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id DC49420D63; Mon, 28 Oct 2019 15:02:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id CF36B20AF6; Mon, 28 Oct 2019 15:02:01 -0400 (EDT) X-Gerrit-PatchSet: 5 Date: Mon, 28 Oct 2019 19:02:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Change some arguments to gdb::string_view instead of name+len X-Gerrit-Change-Id: I2675c6865e0368f9c755a1081088a53aa54dda4c X-Gerrit-Change-Number: 125 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6a46caafff475dd8a8bada62329f982562dd4763 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 28 Oct 2019 15:02:01 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191028190201.CF36B20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00998.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/125 ...................................................................... Patch Set 5: OK, I've updated this patch slightly. With the new version of https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/222, this should be ready to check in. See the updated commit message in that patch for the resolution to the copy/nulltermination issue. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2675c6865e0368f9c755a1081088a53aa54dda4c Gerrit-Change-Number: 125 Gerrit-PatchSet: 5 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Mon, 28 Oct 2019 19:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment