* [review] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
@ 2019-10-28 12:37 ` Tom Tromey (Code Review)
2019-10-28 12:57 ` Simon Marchi (Code Review)
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-28 12:37 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1: Code-Review+2
Thanks. This seems fine to me.
How does include-what-you-use decide if an include is unnecessary?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 12:37:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 8+ messages in thread* [review] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
2019-10-28 12:37 ` Tom Tromey (Code Review)
@ 2019-10-28 12:57 ` Simon Marchi (Code Review)
2019-10-28 13:38 ` Tom Tromey (Code Review)
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-28 12:57 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> Thanks. This seems fine to me.
>
> How does include-what-you-use decide if an include is unnecessary?
I suppose it compiles the file, makes the list of all symbols/types/macros provided by each header file, makes the list of all symbols/types/macros used in the .c file, and reports if some header file did not contribute anything the .c file used.
I haven't tried, but we might need to be a bit careful when preprocessor #ifs or #ifdefs are involved. Since it compiles a particular configuration, as described in a compile_commands.json file, I would guess that it only considers what's kept by the preprocessor in this particular configuration. So it could tell you to remove an include that's actually needed when the other branch of the #ifdef is taken. Though maybe in that case, the include file should be conditionally included, using that same condition.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 12:57:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 8+ messages in thread* [review] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
2019-10-28 12:37 ` Tom Tromey (Code Review)
2019-10-28 12:57 ` Simon Marchi (Code Review)
@ 2019-10-28 13:38 ` Tom Tromey (Code Review)
2019-10-28 15:29 ` Konrad Kleine (Code Review)
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-28 13:38 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1:
> I haven't tried, but we might need to be a bit careful when preprocessor #ifs or #ifdefs are involved. Since it compiles a particular configuration, as described in a compile_commands.json file, I would guess that it only considers what's kept by the preprocessor in this particular configuration. So it could tell you to remove an include that's actually needed when the other branch of the #ifdef is taken. Though maybe in that case, the include file should be conditionally included, using that same condition.
Yeah, I that would be good as well, just because it makes the connection more
explicit.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 13:38:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 8+ messages in thread* [review] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
` (2 preceding siblings ...)
2019-10-28 13:38 ` Tom Tromey (Code Review)
@ 2019-10-28 15:29 ` Konrad Kleine (Code Review)
2019-10-28 15:51 ` Simon Marchi (Code Review)
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Konrad Kleine (Code Review) @ 2019-10-28 15:29 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Tom Tromey
Konrad Kleine has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1:
LGTM if it still compiles and passes tests. I hesitate to give a +1 though :)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Konrad Kleine <kkleine@redhat.com>
Gerrit-Comment-Date: Mon, 28 Oct 2019 15:29:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 8+ messages in thread* [review] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
` (3 preceding siblings ...)
2019-10-28 15:29 ` Konrad Kleine (Code Review)
@ 2019-10-28 15:51 ` Simon Marchi (Code Review)
2019-10-29 21:56 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-29 21:56 ` Sourceware to Gerrit sync (Code Review)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-28 15:51 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1:
> Patch Set 1:
>
> I hesitate to give a +1 though :)
Please don't! Or a -1 if you find something to change.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 15:51:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 8+ messages in thread* [pushed] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
` (4 preceding siblings ...)
2019-10-28 15:51 ` Simon Marchi (Code Review)
@ 2019-10-29 21:56 ` Sourceware to Gerrit sync (Code Review)
2019-10-29 21:56 ` Sourceware to Gerrit sync (Code Review)
6 siblings, 0 replies; 8+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-29 21:56 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Tom Tromey
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Remove unused includes in infcmd.c and infrun.c
include-what-you-use reported this:
../../../src/binutils-gdb/gdb/infcmd.c should remove these lines:
- #include <signal.h> // lines 22-22
- #include "cli/cli-decode.h" // lines 48-48
- #include "cli/cli-utils.h" // lines 56-56
- #include "event-top.h" // lines 38-38
- #include "infcall.h" // lines 57-57
- #include "parser-defs.h" // lines 39-39
../../../src/binutils-gdb/gdb/infrun.c should remove these lines:
- #include <signal.h> // lines 37-37
- #include "cli/cli-script.h" // lines 31-31
- #include "continuations.h" // lines 54-54
- #include "dictionary.h" // lines 45-45
- #include "gdbsupport/gdb_wait.h" // lines 28-28
- #include "interps.h" // lines 55-55
Remove those includes.
Tested by rebuilding, and by quick inspection that the include fields
were indeed unnecessary.
gdb/ChangeLog:
* infcmd.c: Remove includes.
* infrun.c: Remove includes.
Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
---
M gdb/ChangeLog
M gdb/infcmd.c
M gdb/infrun.c
3 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8c12df0..7338ec3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+ * infcmd.c: Remove includes.
+ * infrun.c: Remove includes.
+
+2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+
* ada-lang.h (GROW_VECT): Move to ada-lang.c.
(grow_vect): Remove declaration.
(ada_type_of_array): Remove declaration.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 465d3a1..5ca9933 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -19,7 +19,6 @@
#include "defs.h"
#include "arch-utils.h"
-#include <signal.h>
#include "symtab.h"
#include "gdbtypes.h"
#include "frame.h"
@@ -35,8 +34,6 @@
#include "objfiles.h"
#include "completer.h"
#include "ui-out.h"
-#include "event-top.h"
-#include "parser-defs.h"
#include "regcache.h"
#include "reggroups.h"
#include "block.h"
@@ -45,7 +42,6 @@
#include "observable.h"
#include "target-descriptions.h"
#include "user-regs.h"
-#include "cli/cli-decode.h"
#include "gdbthread.h"
#include "valprint.h"
#include "inline-frame.h"
@@ -53,8 +49,6 @@
#include "inf-loop.h"
#include "continuations.h"
#include "linespec.h"
-#include "cli/cli-utils.h"
-#include "infcall.h"
#include "thread-fsm.h"
#include "top.h"
#include "interps.h"
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 66a066f..d8a6eed 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -25,16 +25,13 @@
#include "frame.h"
#include "inferior.h"
#include "breakpoint.h"
-#include "gdbsupport/gdb_wait.h"
#include "gdbcore.h"
#include "gdbcmd.h"
-#include "cli/cli-script.h"
#include "target.h"
#include "gdbthread.h"
#include "annotate.h"
#include "symfile.h"
#include "top.h"
-#include <signal.h>
#include "inf-loop.h"
#include "regcache.h"
#include "value.h"
@@ -42,7 +39,6 @@
#include "language.h"
#include "solib.h"
#include "main.h"
-#include "dictionary.h"
#include "block.h"
#include "mi/mi-common.h"
#include "event-top.h"
@@ -51,8 +47,6 @@
#include "inline-frame.h"
#include "jit.h"
#include "tracepoint.h"
-#include "continuations.h"
-#include "interps.h"
#include "skip.h"
#include "probe.h"
#include "objfiles.h"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 8+ messages in thread* [pushed] Remove unused includes in infcmd.c and infrun.c
2019-10-27 6:21 [review] Remove unused includes in infcmd.c and infrun.c Simon Marchi (Code Review)
` (5 preceding siblings ...)
2019-10-29 21:56 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-10-29 21:56 ` Sourceware to Gerrit sync (Code Review)
6 siblings, 0 replies; 8+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-29 21:56 UTC (permalink / raw)
To: Simon Marchi, Tom Tromey, gdb-patches
The original change was created by Simon Marchi.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Remove unused includes in infcmd.c and infrun.c
include-what-you-use reported this:
../../../src/binutils-gdb/gdb/infcmd.c should remove these lines:
- #include <signal.h> // lines 22-22
- #include "cli/cli-decode.h" // lines 48-48
- #include "cli/cli-utils.h" // lines 56-56
- #include "event-top.h" // lines 38-38
- #include "infcall.h" // lines 57-57
- #include "parser-defs.h" // lines 39-39
../../../src/binutils-gdb/gdb/infrun.c should remove these lines:
- #include <signal.h> // lines 37-37
- #include "cli/cli-script.h" // lines 31-31
- #include "continuations.h" // lines 54-54
- #include "dictionary.h" // lines 45-45
- #include "gdbsupport/gdb_wait.h" // lines 28-28
- #include "interps.h" // lines 55-55
Remove those includes.
Tested by rebuilding, and by quick inspection that the include fields
were indeed unnecessary.
gdb/ChangeLog:
* infcmd.c: Remove includes.
* infrun.c: Remove includes.
Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
---
M gdb/ChangeLog
M gdb/infcmd.c
M gdb/infrun.c
3 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8c12df0..7338ec3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+ * infcmd.c: Remove includes.
+ * infrun.c: Remove includes.
+
+2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
+
* ada-lang.h (GROW_VECT): Move to ada-lang.c.
(grow_vect): Remove declaration.
(ada_type_of_array): Remove declaration.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 465d3a1..5ca9933 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -19,7 +19,6 @@
#include "defs.h"
#include "arch-utils.h"
-#include <signal.h>
#include "symtab.h"
#include "gdbtypes.h"
#include "frame.h"
@@ -35,8 +34,6 @@
#include "objfiles.h"
#include "completer.h"
#include "ui-out.h"
-#include "event-top.h"
-#include "parser-defs.h"
#include "regcache.h"
#include "reggroups.h"
#include "block.h"
@@ -45,7 +42,6 @@
#include "observable.h"
#include "target-descriptions.h"
#include "user-regs.h"
-#include "cli/cli-decode.h"
#include "gdbthread.h"
#include "valprint.h"
#include "inline-frame.h"
@@ -53,8 +49,6 @@
#include "inf-loop.h"
#include "continuations.h"
#include "linespec.h"
-#include "cli/cli-utils.h"
-#include "infcall.h"
#include "thread-fsm.h"
#include "top.h"
#include "interps.h"
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 66a066f..d8a6eed 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -25,16 +25,13 @@
#include "frame.h"
#include "inferior.h"
#include "breakpoint.h"
-#include "gdbsupport/gdb_wait.h"
#include "gdbcore.h"
#include "gdbcmd.h"
-#include "cli/cli-script.h"
#include "target.h"
#include "gdbthread.h"
#include "annotate.h"
#include "symfile.h"
#include "top.h"
-#include <signal.h>
#include "inf-loop.h"
#include "regcache.h"
#include "value.h"
@@ -42,7 +39,6 @@
#include "language.h"
#include "solib.h"
#include "main.h"
-#include "dictionary.h"
#include "block.h"
#include "mi/mi-common.h"
#include "event-top.h"
@@ -51,8 +47,6 @@
#include "inline-frame.h"
#include "jit.h"
#include "tracepoint.h"
-#include "continuations.h"
-#include "interps.h"
#include "skip.h"
#include "probe.h"
#include "objfiles.h"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 8+ messages in thread