From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78122 invoked by alias); 28 Oct 2019 13:38:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77802 invoked by uid 89); 28 Oct 2019 13:38:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2019 13:38:41 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 032C820D62; Mon, 28 Oct 2019 09:38:39 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id AE2B820465; Mon, 28 Oct 2019 09:38:37 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8DA8120AF6; Mon, 28 Oct 2019 09:38:37 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 28 Oct 2019 13:38:00 -0000 From: "Tom Tromey (Code Review)" To: Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove unused includes in infcmd.c and infrun.c X-Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153 X-Gerrit-Change-Number: 322 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1acc1250e517341ed356355517f0a25c39b7ab6c In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 28 Oct 2019 09:38:37 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191028133837.8DA8120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00986.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322 ...................................................................... Patch Set 1: > I haven't tried, but we might need to be a bit careful when preprocessor #ifs or #ifdefs are involved. Since it compiles a particular configuration, as described in a compile_commands.json file, I would guess that it only considers what's kept by the preprocessor in this particular configuration. So it could tell you to remove an include that's actually needed when the other branch of the #ifdef is taken. Though maybe in that case, the include file should be conditionally included, using that same condition. Yeah, I that would be good as well, just because it makes the connection more explicit. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153 Gerrit-Change-Number: 322 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Marchi Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Mon, 28 Oct 2019 13:38:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment