From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review] [RFC][gdb] Make script-extension strict reject unknown extensions
Date: Tue, 22 Oct 2019 08:52:00 -0000 [thread overview]
Message-ID: <20191022085221.35F312192E@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
Tom de Vries has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
......................................................................
Patch Set 1:
> Patch Set 1:
>
> > Patch Set 1:
> >
> > > Patch Set 1:
> > >
> > > A couple questions about this:
> > > - If specified in -ix or a system gdbinit file, does it prevent reading ~/.gdbinit?
> [...]
> > But for the system gdbinit, it's yes.
> >
> > > - Does it prevent reading a file in --command if it doesn't have the extension?
> >
> > Yes:
> [...]
>
> Hm, personally I would find that behavior surprising, especially for the gdbinit file. But I have no decision power here...
Fixed in patch set 2.
next prev parent reply other threads:[~2019-10-22 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
2019-10-14 16:08 ` Change in binutils-gdb[master]: " Christian Biesinger (Code Review)
2019-10-16 22:20 ` [review] " Christian Biesinger (Code Review)
2019-10-22 8:52 ` [review v2] " Tom de Vries (Code Review)
2019-10-22 8:52 ` Tom de Vries (Code Review) [this message]
2019-10-25 17:32 ` Tom Tromey (Code Review)
2019-10-25 17:46 ` Christian Biesinger (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022085221.35F312192E@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox