From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
Christian Biesinger <cbiesinger@google.com>
Subject: [review v2] [RFC][gdb] Make script-extension strict reject unknown extensions
Date: Fri, 25 Oct 2019 17:46:00 -0000 [thread overview]
Message-ID: <20191025174649.8908D204C9@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
......................................................................
Patch Set 2:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.h
File gdb/cli/cli-cmds.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.h@123
PS2, Line 123: extern void source_script_force (const char *, int);
This should probably have some documentation on what it forces
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576
Gerrit-Change-Number: 40
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 17:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
prev parent reply other threads:[~2019-10-25 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
2019-10-14 16:08 ` Change in binutils-gdb[master]: " Christian Biesinger (Code Review)
2019-10-16 22:20 ` [review] " Christian Biesinger (Code Review)
2019-10-22 8:52 ` Tom de Vries (Code Review)
2019-10-22 8:52 ` [review v2] " Tom de Vries (Code Review)
2019-10-25 17:32 ` Tom Tromey (Code Review)
2019-10-25 17:46 ` Christian Biesinger (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025174649.8908D204C9@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tdevries@suse.de \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox